Conversation
|
I'm a little hesitant to modify the current code base even through a few of them are reusable. I presume to reuse them some renaming and updates might be necessary, so I think adding some tests at first might be a good idea, in order to not break current behavior. This is a WIP PR, so please feel free to leave any comment. @daroczig |
* Make it testable by passing timestamp as argument * Fix the document
0b3da62 to
041d806
Compare
|
These functions are using deprecated V1 API. Is there a plan to remove them in favor of V3?
Also these functions which are fundamental should be migrated easily:
|
|
Or shall we version the functions according to the API? |
|
On a second thoughts we might have to skip the tests requiring authentication until it is possible to have a shared credential for testing. Even though the timestamp can be input as an argument. different credentials would produce different signatures. |
* open_long_market() * close_long_market() * open_short_market() * close_short_market() * default_usdm_filters.MARKET() * execute_usdm_order.MARKET()
|
Now |
The assertive package is archived on CRAN.
This PR is related to #22