Fix file path issues with separate output files#1920
Open
sumanmichael wants to merge 1 commit intodarold:masterfrom
Open
Fix file path issues with separate output files#1920sumanmichael wants to merge 1 commit intodarold:masterfrom
sumanmichael wants to merge 1 commit intodarold:masterfrom
Conversation
- Use proper file path construction with fileparse() and File::Spec->catfile() for all INDEXES_, AUTOINCREMENT_, and LOGICAL_ output files - Ensures correct directory handling when OUTPUT_DIR is specified - Fixes potential issues with file creation in different directory structures - Affects TBSP_INDEXES_, PARTITION_INDEXES_, AUTOINCREMENT_, LOGICAL_, INDEXES_, and FTS_INDEXES_ file generation - Improves consistency with existing file handling patterns in the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found an issue where some of the special output files weren't being created in the right directories when using OUTPUT_DIR or when the main output file had a path.
The problem was that files like INDEXES_* , AUTOINCREMENT_* , LOGICAL_*, etc. were using simple string concatenation instead of proper path handling. This would cause errors like:
When processing tables with identity columns like:
The issue was simple string concatenation creating invalid paths like
AUTOINCREMENT_/tmp/output.sqlinstead of/tmp/AUTOINCREMENT_output.sql.Fixed it by fileparse() to split the path properly and File::Spec->catfile() to put it back together correctly.
This affects these files:
Should be backward compatible since it's just fixing the path construction, not changing what gets generated. Tested with different output directory scenarios and it works as expected now.