Fix issue #32 - separate the keyboard shortcuts in some config file#55
Open
sebojanko wants to merge 3 commits intodarxtrix:masterfrom
Open
Fix issue #32 - separate the keyboard shortcuts in some config file#55sebojanko wants to merge 3 commits intodarxtrix:masterfrom
sebojanko wants to merge 3 commits intodarxtrix:masterfrom
Conversation
The shortcuts are now in a JSON file. The file contains the shortcut key, the name of the method in Python and the name to show to the user.
Owner
|
Thanks, let me get back to you after reviewing this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tried to separate the shortcuts to a JSON file.
The JSON looks like this:
The first element is the shortcut, the second is the name of the method that is called and third is the name showed to the user.
I know letting the user write which method should be called should be avoided but I haven't found any other way to implement this.
Another thing, I used a global variable to save the shortcut key and its name between classes. I've seen you using global variables so I think it should be alright to you.
Another way to do this, without using a global variable, is to read the file twice.
Let me know what you think about this.
This is my first PR ever to an OS project, so I apologize if I did something wrong. Thanks :)