Design Changes - Brush Buttons, Layout, Color#2
Design Changes - Brush Buttons, Layout, Color#2aswathirazak1 wants to merge 2 commits intodash1291:masterfrom
Conversation
… to make canvas full screen
aswathirazak1
changed the title
| box-shadow: 4px 10px 14px 0px rgba(168,137,26,0.4); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
extra blank lines could be removed here
|
|
||
| .toolbox__item:hover { | ||
| box-shadow: 4px 10px 14px 0px rgba(0,0,0,0.15); | ||
| } |
There was a problem hiding this comment.
indentation issue. 4 spaces before box-shadow instead of 8. } should be shifted to the beginning of the line
| position:absolute; | ||
| left:50px; | ||
| bottom: 50px; | ||
| width:1600px; |
There was a problem hiding this comment.
this is too wide. we might have to think about how to make it scale according to the viewport width until some minimum width. narrower than that will qualify for some mobile effort which could be done later
| align-items: center; | ||
| #key-selection-area { | ||
| position:absolute; | ||
| left:50px; |
| font-family: "Benton Sans", "Helvetica Neue", helvetica, arial, sans-serif; | ||
| margin: 2em; | ||
| background-color: #5c5470; | ||
| background-image: linear-gradient(100deg, #8256D6, #5943C8, #3C39BC); |
|
|
||
| var tool = 0 // 0 = pen, 1 = eraser | ||
|
|
||
|
|
There was a problem hiding this comment.
we should avoid extraneous changes
| viz.text('Draw something here', WIDTH / 2 - 150, HEIGHT / 2) | ||
| viz.textSize(20) | ||
| viz.fill(300) | ||
| viz.text('Scribble, quibble, dribble, you know what to do. Hit spacebar when you’re done.', WIDTH / 2 - 300, HEIGHT / 2) |
| viz.fill(150) | ||
| viz.text('Draw something here', WIDTH / 2 - 150, HEIGHT / 2) | ||
| viz.textSize(20) | ||
| viz.fill(300) |
There was a problem hiding this comment.
fill() takes color as a parameter. 300 means gray value = 300 which is out of bounds (0-255 being the permissible range). check this out - https://p5js.org/learn/color.html
| viz.fill(150) | ||
| viz.text('Preparing stuff', WIDTH / 2 - 100, HEIGHT / 2) | ||
| viz.textSize(20) | ||
| viz.fill(300) |
There was a problem hiding this comment.
fill() takes color as a parameter. 300 means gray value = 300 which is out of bounds (0-255 being the permissible range). check this out - https://p5js.org/learn/color.html
| color: #333; | ||
| background: #dbd8e3; | ||
| background: #FF90C3; | ||
| box-shadow: 4px 10px 14px 0px rgba(168,137,26,0.4); |
2 participants
hey, please review code?