Skip to content

Conversation

@PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Dec 8, 2025

Issue being fixed or feature implemented

AI implemented: bitcoin#22708 (comment)

A primary goal being to modify our flatpak to have the container use wayland instead of X11. Currently, Dash Core crashes if a system online exposes wayland and no X11 compatibility layer.

How Has This Been Tested?

Ran on fedora 43 Gnome VM forcing wayland (Qt on Gnome will always fallback to X11 unless forced, inside KDE (knst please test) it should use wayland natively.

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 23.1 milestone Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

Please coordinate with the authors of these PRs to avoid merge conflicts.

((gnu packages python-crypto) #:select (python-asn1crypto))
((gnu packages tls) #:select (openssl))
((gnu packages version-control) #:select (git-minimal))
((gnu packages xml) #:select (expat))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear why this is different

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
((gnu packages xml) #:select (expat))
(gnu packages xml)

$(package)_config_opts := --enable-option-checking --disable-dependency-tracking
$(package)_config_opts += --enable-shared --disable-static --disable-documentation
$(package)_config_opts += --disable-dtd-validation --with-host-scanner
$(package)_cflags += -D_GNU_SOURCE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable difference

Comment on lines +11 to +12
# libffi uses GNU C extensions (asm, ssize_t) that require gnu11 instead of c11
$(package)_cflags := -std=gnu11
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable difference


export CONTAINER_NAME=ci_native_tsan
export PACKAGES="clang-19 llvm-19 libclang-rt-19-dev libc++abi-19-dev libc++-19-dev python3-zmq"
export PACKAGES="clang-19 llvm-19 libclang-rt-19-dev libc++abi-19-dev libc++-19-dev python3-zmq libexpat1-dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update also doc/build-unix.md and other related files

@knst
Copy link
Collaborator

knst commented Dec 9, 2025

it runs, but I think I found 3 bugs immediately.

image
  1. wrong icon in the title and task manager
  2. fonts are not scaled (I use scale due to high resolution)
  3. Trans...tion tab doesn't fit - probaby wrongly calculated "min size" for controls

@knst
Copy link
Collaborator

knst commented Dec 10, 2025

One bug less: without wayland I have the same issue with "Transaction" tab when window has the minimal size

image

@github-actions
Copy link

This pull request has conflicts, please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants