Bosses known#68
Conversation
Remove some redundant bank-crossing warnpcs in main.asm
| .skip | ||
| RTS | ||
|
|
||
| DrawBossesKnown: |
There was a problem hiding this comment.
We probably need a way to disable this for non Bosses Known seeds, right? Maybe I'm missing that. Could be writing all zeros to the boss values in tables.asm.
There was a problem hiding this comment.
Yeah, mentioned this on discord but I was thinking I'd get a minimal draft together and then maybe we could figure out the exact details of what to display, where and when etc.
| LDA.w $0000,X : BIT.w VanillaItemsCollected | ||
| BNE .toggle | ||
| LDY.w #DashItemsEquipped | ||
| INC.b $3A |
There was a problem hiding this comment.
Is it guaranteed that $3A is zero when we enter this function?
There was a problem hiding this comment.
Doesn't seem to be used for anything according to the disassembly. We should probably zero it out somewhere when loading the menu just to be safe, that will keep it open for temporary use elsewhere too.
2 participants
No description provided.