Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <cdap.version>6.1.2</cdap.version> | ||
| <cdap.version>6.8.0-SNAPSHOT</cdap.version> |
There was a problem hiding this comment.
It is changed to latest version becuase for older versions the build was not getting successful.
pom.xml
Outdated
| <groupId>io.cdap.cdap</groupId> | ||
| <artifactId>cdap-data-pipeline</artifactId> | ||
| <version>${cdap.version}</version> | ||
| <version>6.4.0</version> |
There was a problem hiding this comment.
why are we hardcoding the version instead of taking from the property?
| <cdap.version>6.1.2</cdap.version> | ||
| <cdap.version>6.8.0-SNAPSHOT</cdap.version> | ||
| <powermock.version>2.0.2</powermock.version> | ||
| <cdap.data.pipeline.version>6.4.0</cdap.data.pipeline.version> |
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <cdap.version>6.1.2</cdap.version> | ||
| <cdap.version>6.8.0-SNAPSHOT</cdap.version> |
There was a problem hiding this comment.
you shouldn't need to bump cdap.version as we aren't adding a dependency on CDAP APIs that have been added in 6.8.0-SNAPSHOT
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>30.1.1-jre</version> |
There was a problem hiding this comment.
why are you adding guava dependency here? If it's needed for e2e-tests, can you add the dependency under e2e-tests profile?
| And Verify the pipeline status is "Succeeded" | ||
| Then Close the pipeline logs | ||
| Then Validate OUT record count is equal to IN record count | ||
| Then Verify column: "afFieldName" is added in target BigQuery table: "bqTargetTable" |
There was a problem hiding this comment.
can we also verify that the data stored in the new column is correct?
3 participants
@rmstar @itsankit-google Please review.
cc @sawantpritam