Open
Conversation
psainics
force-pushed
the
orc-upsert
branch
2 times, most recently
from
8cacac6 to
5ea49a5
Compare
prince-cs
approved these changes
Feb 19, 2026
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleETLDBOutputFormat.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleETLDBOutputFormat.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceDBRecord.java
Outdated
Show resolved
Hide resolved
Contributor
itsankit-google
left a comment
itsankit-google
left a comment
There was a problem hiding this comment.
Please add e2e tests for upsert / update cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for upsert operations in the Oracle batch sink plugin.
OracleETLDBOutputFormatthat extendsETLDBOutputFormatand implements theconstructUpsertQuerymethod, generating an Oracle-compatible MERGE-based upsert SQL statement.OracleSinkto use the newOracleETLDBOutputFormatby adding an output context withSinkOutputFormatProvider.UI Update