Conversation
The test for DicomImageRedactorEngine._rescale_dcm_pixel_array() was copy-pasted under the name test_check_if_greyscale_happy_path, so it rebound the module-level name and pytest silently stopped collecting the real _check_if_greyscale() test above it. Rename the second function to test_rescale_dcm_pixel_array_happy_path (matching its section header and docstring) so both run again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
In
presidio-image-redactor/tests/test_dicom_image_redactor_engine.py, the happy-path test forDicomImageRedactorEngine._rescale_dcm_pixel_array()(section header at L127, docstring says_rescale_dcm_pixel_array) was copy-pasted under the nametest_check_if_greyscale_happy_path— the same name as the real_check_if_greyscale()test at L109.The second
defrebinds the module-level name, so pytest only collects the later one and the_check_if_greyscaletest (RGB vs. MONOCHROME detection) has silently not been running.ruffflags it asF811 Redefinition of unused test_check_if_greyscale_happy_path.This PR renames the second function to
test_rescale_dcm_pixel_array_happy_path, matching its section header and docstring. No other changes.Verification
Run from
presidio-image-redactor/afteruv sync --locked --group dev:pytest tests/test_dicom_image_redactor_engine.py --collect-only-k "greyscale or rescale"_check_if_greyscalecases:0_ORIGINAL.dcm → True,RGB_ORIGINAL.dcm → False)The
F811for this file disappears; no new ruff findings.🤖 Generated with Claude Code