Skip to content

fix(core): pin time below incompatible 0.3.52#784

Closed
sundy-li wants to merge 1 commit into
mainfrom
fix/core-time-cookie-compat
Closed

fix(core): pin time below incompatible 0.3.52#784
sundy-li wants to merge 1 commit into
mainfrom
fix/core-time-cookie-compat

Conversation

@sundy-li

@sundy-li sundy-li commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

  • constrain the direct time dependency used with cookie 0.18.1 to versions below 0.3.52
  • prevent Node.js binding CI from resolving the incompatible time parsing API change that breaks cookie compilation

Verification

  • cargo metadata --format-version 1 --manifest-path bindings/nodejs/Cargo.toml --locked --no-deps
  • cd bindings/nodejs && pnpm prettier --check .

Notes

  • The failing CI job was build-nodejs in run 28484676819. Its log showed cookie 0.18.1 failing against time 0.3.52 with E0061 because time::parsing::Parsable::parse now requires a second defaults argument.
  • Full local pnpm napi build / cargo build could not complete because local crates.io access repeatedly timed out while downloading the index.

@sundy-li sundy-li requested a review from youngsofun July 1, 2026 01:49
@sundy-li sundy-li force-pushed the fix/core-time-cookie-compat branch from b97ea4f to 1ec6cb6 Compare July 1, 2026 06:20
@sundy-li sundy-li force-pushed the fix/core-time-cookie-compat branch from 1ec6cb6 to 6ef8baf Compare July 1, 2026 06:32
@youngsofun

youngsofun commented Jul 1, 2026

Copy link
Copy Markdown
Member

retry suceeded https://github.com/databendlabs/bendsql/actions/runs/28484676819
bug seems to be fixed by time v0.3.53 just release https://crates.io/crates/time

@sundy-li sundy-li closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants