Skip to content

feat(meta-service): add metrics for stream access operations#18210

Merged
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer:319-stream-metrics
Jun 21, 2025
Merged

feat(meta-service): add metrics for stream access operations#18210
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer:319-stream-metrics

Conversation

@drmingdrmer
Copy link
Copy Markdown
Member

@drmingdrmer drmingdrmer commented Jun 21, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(meta-service): add metrics for stream access operations

Previously, stream-based operations like mget and list were only counted
as single RPCs in our metrics system, despite potentially sending large
volumes of data. For example, a single list RPC fetching a large directory
would appear the same as a simple operation in our metrics.

This commit adds granular metrics to track the actual number of items sent
in stream operations with the following counters:

metasrv_meta_network_stream_get_item_sent_total
metasrv_meta_network_stream_mget_item_sent_total
metasrv_meta_network_stream_list_item_sent_total

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

Previously, stream-based operations like `mget` and `list` were only counted
as single RPCs in our metrics system, despite potentially sending large
volumes of data. For example, a single `list` RPC fetching a large directory
would appear the same as a simple operation in our metrics.

This commit adds granular metrics to track the actual number of items sent
in stream operations with the following counters:

```
metasrv_meta_network_stream_get_item_sent_total
metasrv_meta_network_stream_mget_item_sent_total
metasrv_meta_network_stream_list_item_sent_total
```
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jun 21, 2025
@drmingdrmer drmingdrmer marked this pull request as ready for review June 21, 2025 05:31
@drmingdrmer drmingdrmer requested a review from everpcpc June 21, 2025 05:31
@drmingdrmer drmingdrmer merged commit e366f7e into databendlabs:main Jun 21, 2025
154 of 157 checks passed
@drmingdrmer drmingdrmer deleted the 319-stream-metrics branch June 21, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant