feat(meta-service): add metrics for stream access operations#18210
Merged
drmingdrmer merged 1 commit intodatabendlabs:mainfrom Jun 21, 2025
Merged
feat(meta-service): add metrics for stream access operations#18210drmingdrmer merged 1 commit intodatabendlabs:mainfrom
drmingdrmer merged 1 commit intodatabendlabs:mainfrom
Conversation
Previously, stream-based operations like `mget` and `list` were only counted as single RPCs in our metrics system, despite potentially sending large volumes of data. For example, a single `list` RPC fetching a large directory would appear the same as a simple operation in our metrics. This commit adds granular metrics to track the actual number of items sent in stream operations with the following counters: ``` metasrv_meta_network_stream_get_item_sent_total metasrv_meta_network_stream_mget_item_sent_total metasrv_meta_network_stream_list_item_sent_total ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat(meta-service): add metrics for stream access operations
Previously, stream-based operations like
mgetandlistwere only countedas single RPCs in our metrics system, despite potentially sending large
volumes of data. For example, a single
listRPC fetching a large directorywould appear the same as a simple operation in our metrics.
This commit adds granular metrics to track the actual number of items sent
in stream operations with the following counters:
Tests
Type of change
Related Issues
This change is