Conversation
update dev with master change
create trackHub directories for the BED sets
stolarczyk
left a comment
stolarczyk
left a comment
There was a problem hiding this comment.
let's also work on code style/formatting. I noticed things like:
- mixed use of
''and""for strings - lines over 80 chars
- missing spaces between function parameters
pipelines/bedbuncher.py
Outdated
| 'shortLabel': 'BEDBASE_'+args.bedset_name, | ||
| 'longLabel': args.bedset_name + ' signal tracks', | ||
| 'genomesFile': "genomes.txt", | ||
| 'email': 'bx2ur@virginia.edu', |
There was a problem hiding this comment.
what email should I use?
There was a problem hiding this comment.
maybe the one we use for auto uploading software to pypi? I can't seem to find it. @nsheff do you remember the email address?
|
@stolarczyk do you have a linting system you recommend for Python style to help people become familiar with good style? |
|
no, but adding one is a great idea. I'll see what are the options and test things out. |
|
it looks like black is the most used one, it's also developed by a Python core developer. I tested it in bbconf and it worked perfectly fine: https://github.com/databio/bbconf/pull/9/checks?check_run_id=1954455626 What's interesting, the default line length cutoff is 88: https://black.readthedocs.io/en/stable/the_black_code_style.html#line-length |
3 participants
Uh oh!
There was an error while loading. Please reload this page.