Claude/fix tpcds ci errors#61
Merged
Merged
Conversation
Fixes the 4 failing queries from the first TPC-DS benchmark run:
- q6 (SCALAR_SUBQUERY_TOO_MANY_ROWS): d_month_seq was computed as
FLOOR(id/30) which produced multiple distinct values per (year, month).
Changed to (year-1900)*12 + month-1 so the standard TPC-DS scalar
subquery (SELECT DISTINCT d_month_seq WHERE d_year=X AND d_moy=Y)
returns exactly one row. Same treatment for d_quarter_seq and d_week_seq.
- q30 (SCALAR_SUBQUERY_TOO_MANY_ROWS): Rewrote the correlated scalar
subquery (SELECT AVG(...) WHERE ctr1.ctr_state = ctr2.ctr_state) as an
explicit JOIN on a precomputed per-state average CTE. Semantically
identical, avoids Spark's decorrelation ambiguity on synthetic data.
- q48 (query bug): Removed hd_dep_count references without the
household_demographics JOIN (the real TPC-DS q48 doesn't use
household_demographics either). Also fixed the degenerate
s_state IN ('TN','TN',...) list and wider net_profit ranges.
- q58, q90 (DIVIDE_BY_ZERO in Spark 4 ANSI mode): Added
spark.sql.ansi.enabled=false to both the data-gen step in the workflow
and the query runner script. This is the standard setting for TPC-DS.
https://claude.ai/code/session_017eG2kCEbZdms92VdUThAfv
- Use dlcdn.apache.org as primary download source (much faster than archive.apache.org) with fallback to archive if CDN lacks the version - Temporarily disable Spark 4.0.2 matrix entry Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The /history/{appId}/dataflint/ route issues a 302 to the SPA entry,
which curl was treating as failure. Add -L to follow redirects.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.