Extract SQL-plan instrumentation into standalone repo#78
Closed
minskya wants to merge 1 commit into
Closed
Conversation
Move the operator-timing instrumentation feature out of dataflint/spark into a self-contained project seed (instrumentation-repo/) that depends on the published io.dataflint:dataflint-common artifact and publishes to GitHub Packages. Removed from spark-plugin: - common: TimedExec, MetricsUtils, Accelerator, GraphDurationAttribution - pluginspark3/pluginspark4: DataFlintInstrumentationExtension - pluginspark3/src/test: the entire instrumentation regression suite - pluginspark4 build block pulling in the moved DataFlintCodegenFallbackSpec Kept as the loose-coupling contract in dataflint-common: - INSTRUMENT_* config constants + registerInstrumentationExtension (loads the extension by class name via spark.sql.extensions) - api.ResolvedStageGroup The new repo seed compiles (spark3/spark4 + test suite) and assembles fat jars; the trimmed spark-plugin (common/spark3/spark4) still compiles. See INSTRUMENTATION-EXTRACTION.md and instrumentation-repo/NEW-REPO-SETUP.md.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the operator-timing instrumentation feature out of dataflint/spark into
a self-contained project seed (instrumentation-repo/) that depends on the
published io.dataflint:dataflint-common artifact and publishes to GitHub
Packages.
Removed from spark-plugin:
Kept as the loose-coupling contract in dataflint-common:
(loads the extension by class name via spark.sql.extensions)
The new repo seed compiles (spark3/spark4 + test suite) and assembles fat
jars; the trimmed spark-plugin (common/spark3/spark4) still compiles.
See INSTRUMENTATION-EXTRACTION.md and instrumentation-repo/NEW-REPO-SETUP.md.