Skip to content

Reject trailing terminators in provider candidates #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataforxyz merged 1 commit into from
Jul 30, 2026
Merged

Reject trailing terminators in provider candidates #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions provider/protected-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ test("rejects substitution, writable artifacts, noncanonical versions, and non-l
["providerVersion", "01.0.0"],
["providerVersion", "1.0.0-01"],
["providerVersion", "latest"],
...["\n", "\r", "\u2028", "\u2029"].map((terminator) => ["providerVersion", `1.2.3${terminator}`] as [string, unknown]),
["providerDigest", "A".repeat(64)],
["providerDigest", "a".repeat(63)],
...["\n", "\r", "\u2028", "\u2029"].map((terminator) => ["providerDigest", `${"a".repeat(64)}${terminator}`] as [string, unknown]),
["artifactPath", "/usr/lib/agent-intercom/providers/codex/../evil/provider.mjs"],
["artifactPath", "/tmp/codex/provider.mjs"],
["artifactOwnerUid", 1000],
Expand Down
3 changes: 2 additions & 1 deletion provider/protected-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ function readProviderVersion(value: unknown): string {
if (
typeof value !== "string"
|| value.length > 128
|| /[\r\n\u2028\u2029]/.test(value)
|| !CANONICAL_SEMANTIC_VERSION.test(value)
) {
invalid("$candidate.providerVersion", "must be a canonical semantic version");
Expand All @@ -103,7 +104,7 @@ function readProviderVersion(value: unknown): string {
}

function readProviderDigest(value: unknown): string {
if (typeof value !== "string" || !/^[a-f0-9]{64}$/.test(value)) {
if (typeof value !== "string" || value.length !== 64 || !/^[a-f0-9]{64}$/.test(value)) {
invalid("$candidate.providerDigest", "must be a lowercase SHA-256 digest");
}
return value;
Expand Down
Loading