Repository navigation
Conversation
A native plan node can still contain host-exact scalar evaluation, so operator substitution alone is not enough to explain execution placement. Record the final function-to-engine assignment after planner admission, retain the reason for whole-Calc JVM scheduling, and summarize nodes with JVM work at compile time.\n\nKeep the diagnostic focused on SQL functions, UDFs, and casts whose semantics can change placement; omit arithmetic, comparison, and boolean operators.
Author
|
@liuyongvs PTAL~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A
NativeCalcorNativeFilterin the physical plan does not necessarily mean that every scalar expression runs in Rust. The node can still contain host-exact scalar upcalls or a whole-Calc Flink-generated evaluator.Previously, the planner summary only reported operator substitution. A plan could therefore report that all operators were substituted natively while some functions still executed on the JVM, with no compile-time diagnostic explaining that placement.
What changed
nativeandjvm.With
-Dstreamfusion.logFallbackReasons=true, function assignments are emitted atINFO; otherwise they remain available atDEBUG.Example mixed execution:
Example whole-Calc JVM execution:
The planner summary now also reports the number of admitted Calc/filter nodes that contain JVM functions.
Testing
IFexpressions requiring row-major JVM evaluation.