Conversation
Collaborator
|
Thanks @sesteves! |
gabotechs
pushed a commit
that referenced
this pull request
Sep 26, 2026
## Summary - When a worker channel ends without a final report, complete the planned task with an empty metrics or dynamic-filter report. - Skip plan-node metric rewriting for unexecuted tasks rather than inventing execution metrics. - Enable the regression test from #751 and verify both rewrite paths after an AQE task is left unexecuted. Static and adaptive planning share this coordinator receive path. Tested on devspace: 15 metrics integration tests, four dynamic-filter integration tests, and two dynamic-filter display unit tests pass; formatting passes. Fixes #739
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
maintimes out after 10 seconds (twice); the same test passes with the proposed fix.Refs #739