chore: Add config flag for remote dynamic filters usage - #754
Merged
jayshrivastava merged 2 commits intoSep 26, 2026
Merged
jayshrivastava merged 2 commits into
jayshrivastava merged 2 commits into
Conversation
Contributor
Author
|
@jayshrivastava Here you go! |
jayshrivastava
approved these changes
Sep 26, 2026
| assert_eq!(display_plan_ascii(plan.as_ref(), false), original_display); | ||
|
|
||
| if expect_dynamic_filter_updates { | ||
| if let Some(expect_updates) = expect_dynamic_filter_updates { |
Collaborator
There was a problem hiding this comment.
I'll leave a note to remove this in #639, after all remote dynamic filtering is working. For now, it makes sense because there's no other way to really assert this.
After that's merged, we will get this information from the plan snapshots. The snapshots will show if consumers got updates or not.
gabotechs
reviewed
Sep 28, 2026
|
|
||
| /// Enables or disables the use of distributed dynamic filters across network boundaries. This | ||
| /// does not affect dynamic filter pushdown intra-stage. | ||
| fn with_distributed_dynamic_filters_used(self, enabled: bool) -> Result<Self, DataFusionError>; |
Collaborator
There was a problem hiding this comment.
The convention is to name these after the the DistributedConfig property it's controlling.
As this is controlling remote_dynamic_filters this should be called:
with_distributed_remote_dynamic_filtersset_distributed_remote_dynamic_filters
jayshrivastava
added a commit
that referenced
this pull request
Sep 28, 2026
…ic_filters (#755) Addresses #754 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
As a follow up to this comment, this PR adds a config flag to enable/disable the use of remote dynamic filters.
It updates
src/dynamic_filtering/mod.rs's helpers with the distinction between local and remote dynamic filters, and gates the remote-only behavior around calls toorphan_dynamic_filter_consumersand when registering remote dynamic filter producer IDs and when registering tasks with the dynamic filter registry.Testing
Adds unit and snapshot tests showing the effects of disabling this flag.