fix: gate Iceberg test utilities behind the integration feature - #757
Open
alexanderbianchi wants to merge 3 commits into
Open
alexanderbianchi wants to merge 3 commits into
alexanderbianchi wants to merge 3 commits into
Conversation
alexanderbianchi
marked this pull request as ready for review
September 30, 2026 23:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate Iceberg's
test_utilswith#[cfg(any(feature = "integration", test))], matching the main DFD crate. Production builds no longer compile the fixtureinclude_str!expressions, so consumers can vendor onlyiceberg/without the sibling test data.integrationfor the six integration-test modules that import these helpers; unit tests retain access throughcfg(test).testdata/iceberg/. This replaces the earlier fixture-relocation approach.test_utilsmust now enableintegration.No codec/runtime or dependency changes. Integration tests still use the repository fixtures; this does not make feature-enabled crate-only copies self-contained.