Skip to content

fix: gate Iceberg test utilities behind the integration feature - #757

Open
alexanderbianchi wants to merge 3 commits into
datafusion-contrib:mainfrom
alexanderbianchi:iceberg-test-utils-fixtures
Open

alexanderbianchi wants to merge 3 commits into
datafusion-contrib:mainfrom
alexanderbianchi:iceberg-test-utils-fixtures

Conversation

@alexanderbianchi

@alexanderbianchi alexanderbianchi commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Gate Iceberg's test_utils with #[cfg(any(feature = "integration", test))], matching the main DFD crate. Production builds no longer compile the fixture include_str! expressions, so consumers can vendor only iceberg/ without the sibling test data.

  • Require integration for the six integration-test modules that import these helpers; unit tests retain access through cfg(test).
  • Keep fixtures and their paths unchanged under testdata/iceberg/. This replaces the earlier fixture-relocation approach.
  • Update the documented test command and feature description. Callers importing test_utils must now enable integration.

No codec/runtime or dependency changes. Integration tests still use the repository fixtures; this does not make feature-enabled crate-only copies self-contained.

@alexanderbianchi alexanderbianchi changed the title fix: keep Iceberg test fixtures inside the crate fix: gate Iceberg test utilities behind the integration feature Sep 30, 2026
@alexanderbianchi
alexanderbianchi marked this pull request as ready for review September 30, 2026 23:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant