feat: support decode-time Iceberg runtime selection - #758
Open
alexanderbianchi wants to merge 2 commits into
Open
alexanderbianchi wants to merge 2 commits into
alexanderbianchi wants to merge 2 commits into
Conversation
alexanderbianchi
marked this pull request as ready for review
October 1, 2026 00:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow a codec registered at startup to select a worker query's Iceberg runtime during plan decoding. This supports load/priority isolation when queries use different CPU runtimes while sharing a dedicated I/O runtime; it is not a data-correctness fix or a measured performance improvement.
IcebergCodec::new_with_runtime_resolver, taking a fallible closure over the decodingTaskContext.new()andDefaultfixed-runtime behavior, encoding, and the wire format. Runtime handles remain local, and CPU/I/O policy stays with the application.Validation
cargo fmt --all -- --checkcargo test --locked -p datafusion-distributed-iceberg --features integration— 88 unit/integration tests passed before the documentation-only cleanup.cargo test --locked -p datafusion-distributed-iceberg --features integration --doc— the remaining doctest passed after removing the verbose example.cargo clippy --locked -p datafusion-distributed-iceberg --all-targets --all-features -- -D warningsRUSTDOCFLAGS='-D warnings' cargo doc --locked -p datafusion-distributed-iceberg --no-deps --all-featuresNew codec tests probe runtime IDs through the handles installed in decoded fixture scans: fixed/default compatibility, two query CPU runtimes sharing distinct I/O, and resolver-error propagation. Temporarily bypassing resolution made all four new tests fail; restoring it passed. These are focused codec tests, not an end-to-end scheduler or performance test.