fix: keep catalog skill references self-contained - #146
Open
danielAsaboro wants to merge 1 commit into
Open
Conversation
danielAsaboro
marked this pull request as ready for review
August 10, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/directoryProblem
The five catalog skills cited
../shared-references/datahub-cli-reference.md. The documentednpx skills add datahub-project/datahub-skillsflow discovers and installs the skill directories, but does not install that sibling directory. This leaves an installed skill with a reference that escapes its installation root and points to a missing file.The source tree now keeps one canonical reference document while skill-local symlinks let the Skills CLI dereference that document into each standalone installation.
Validation
python3 -m unittest tests/test-catalog-skill-installation.py -vnpx --yes markdownlint-cli2@0.21.0 --config .markdownlint-cli2.yaml '**/*.md' '#node_modules'(165 files, 0 errors)npx --yes prettier@4.0.0-alpha.8 --check ...git diff --checkThe model-driven
tests/run-tests.shsuite could not start locally because the Claude CLI test dependency is not authenticated; it exited before executing its first assertion.