feat: DM-4759 model the unlicensed features a ruleset uses - #49
Open
cph-datamasque wants to merge 1 commit into
Open
cph-datamasque wants to merge 1 commit into
cph-datamasque wants to merge 1 commit into
Conversation
cph-datamasque
force-pushed
the
DM-4759-license-warnings
branch
from
September 17, 2026 23:11
6e9ea3d to
c5e8c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
unlicensed_feature_warningstoRuleset: one sentence per feature the ruleset uses that the server's licence does not allow.It is empty when the ruleset needs nothing its licence withholds, and
Noneuntil the ruleset has passed validation — which is not the same as having no warnings, and the tests pin that distinction.Requires server version 3.26.18, which is where DM-4759 lands.