Skip to content

Reduce warn logs noise#1268

Open
milanmajchrak wants to merge 3 commits intodtq-devfrom
internal/remove-wrong-warn-logs
Open

Reduce warn logs noise#1268
milanmajchrak wants to merge 3 commits intodtq-devfrom
internal/remove-wrong-warn-logs

Conversation

@milanmajchrak
Copy link
Collaborator

Problem description

There is a lot of noise from this warn log No such configuration property: *.
There are at least 10 logs per a minute like that.

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

Copilot AI review requested due to automatic review settings March 13, 2026 09:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces REST API log noise by changing how 4xx client errors are logged in DSpaceApiExceptionControllerAdvice, specifically downgrading HTTP 404 responses from WARN to DEBUG.

Changes:

  • Refactored 4xx logging into a new logClientError(...) helper.
  • Logged 404 (NOT_FOUND) at DEBUG while keeping other 4xx responses at WARN.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces REST API WARN log noise by making 404 (NOT_FOUND) responses optionally log at DEBUG instead, controlled via a new runtime configuration property.

Changes:

  • Add logging.server.debug-404 configuration option (default enabled in dspace.cfg) to downgrade 404 logging to DEBUG.
  • Refactor 4xx logging in DSpaceApiExceptionControllerAdvice into a shared helper which applies the 404 rule.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
dspace/config/dspace.cfg Introduces logging.server.debug-404 with explanatory comments and default true.
dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java Adds config constant + helper methods to log 404 at DEBUG and other 4xx at WARN; routes existing WARN logging through the helper.

You can also share your feedback on Copilot code review. Take the survey.

@milanmajchrak milanmajchrak requested a review from vidiecan March 13, 2026 11:00
@milanmajchrak milanmajchrak removed the request for review from vidiecan March 13, 2026 11:02
@milanmajchrak milanmajchrak requested a review from vidiecan March 13, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants