Add dr dependency install to recipe template's install task - #914
Open
tsdaemon wants to merge 1 commit into
Open
Add dr dependency install to recipe template's install task#914tsdaemon wants to merge 1 commit into
tsdaemon wants to merge 1 commit into
Conversation
Carson asked in Slack thread to keep the default recipe Taskfile template in sync with recipe-datarobot-agent-application#872, which consolidated tool installation behind `dr dependency install` driven by versions.yaml. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014AENc35crjzvpEE3cbywuE
Code OwnershipCli Maintainers
Review requested from the teams above. Labels will be removed automatically upon approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
recipe-datarobot-agent-application consolidated all tool installation
behind
dr dependency install, driven by.datarobot/cli/versions.yaml,and removed the old ad-hoc install paths from its Taskfiles
(datarobot/recipe-datarobot-agent-application#872, and the follow-up
"Remove old installation path" commit that added
dr dependency installto
task install). Carson asked in Slack to keep this CLI's defaultrecipe template in sync so every new recipe gets the same up-to-date
dependency install step out of the box.
CHANGES
dr dependency installas the first step of theinstalltask incmd/task/run/testdata/recipe/.Taskfile.template, the default templateused to generate a recipe's root
Taskfile.yml.TESTING
go test ./cmd/task/run/...task lintRELATED
🤖 Generated with Claude Code
https://claude.ai/code/session_014AENc35crjzvpEE3cbywuE
Note
Low Risk
Single-line addition to a testdata template used for recipe scaffolding; no runtime or security-sensitive logic changes in this repo.
Overview
Aligns the default recipe
Taskfiletemplate with consolidated CLI dependency installation.New recipes generated from
cmd/task/run/testdata/recipe/.Taskfile.templatenow rundr dependency installas the first step in theinstalltask, before the existinguv/datarobot_early_access[core]install block anddr task run install. This mirrors the agent-application recipe pattern driven by.datarobot/cli/versions.yamlso greenfield projects get tool installs from the same path out of the box.Reviewed by Cursor Bugbot for commit 5a86599. Configure here.