A10 PIX-LINK example changes - #7
Draft
Python1320 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an example for A10 PIX-LINK cameras the following changes are required.
Audio stream is not correct: you can almost hear the correct audio. It seems to fall behind, but it's not two channels or double sampling rate, will have to investigate more, the quality is awful in any case.
Obviously not to be merged as is, since we need to come up with an architecture to support either all cameras at once (multiple broadcast) or make a camera selector for required cameras (there are more than these two keys).
Discussion about the keys can be found here.