fix(scripts): CI lint for auditorpackgen#168
Merged
Merged
Conversation
Fix rangeValCopy (index loop), gofumpt alignment, and manifest WriteFile mode 0600 so CI lint and format check pass on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure on main after #167 merge (
golangci-lint+gofmtformat check).rangeValCopy: index loop over scenarios slicegofumpt: manifest map alignmentgosec G306: manifest.json written with0600permissionsTest plan
golangci-lint run ./scripts/auditorpackgen/...— 0 issuesgofumpt -wappliedNote
Low Risk
Formatting and file-permission tweaks only; no change to evidence generation or signing logic.
Overview
Unblocks CI on
scripts/auditorpackgen/main.goafter lint/format failures on main.The scenario loop now uses an index range (
for i := range scenarioswithscenarios[i]) instead of ranging by value, satisfying rangeValCopy. Manifest map literals were re-aligned for gofumpt.manifest.jsonis written with mode0600instead of0644, matching other auditor-pack outputs and addressing gosec G306.Reviewed by Cursor Bugbot for commit a389f35. Configure here.