Add inline block support for Github / NPM badge, tweak labels#97
Open
arcataroger wants to merge 3 commits intomainfrom
Open
Add inline block support for Github / NPM badge, tweak labels#97arcataroger wants to merge 3 commits intomainfrom
arcataroger wants to merge 3 commits intomainfrom
Conversation
Member
|
Hey @arcataroger, the label tweaks for long monorepo paths (point 1) are a nice improvement 👍 However I'm not a fan of the inline block support (point 2). These GitHub/NPM badges are not meant to be used inline within running text — it looks odd and breaks the reading flow. In the wild, badges like these are always used as a standalone "header" block at the top of READMEs or doc pages, never sprinkled inside paragraphs or list items as spans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvements to the new badge functionality:
Before / After
Long repo names
Inline blocks