<ExampleComponent/>: Use HTML details accordion instead of custom JS button#98
Open
arcataroger wants to merge 9 commits intomainfrom
Open
<ExampleComponent/>: Use HTML details accordion instead of custom JS button#98arcataroger wants to merge 9 commits intomainfrom
<ExampleComponent/>: Use HTML details accordion instead of custom JS button#98arcataroger wants to merge 9 commits intomainfrom
Conversation
Contributor
Author
|
Going to make a few more tweaks next week. The accordions are fixed but the example tabs in different languages are broken. |
This reverts commit a53be91.
arcataroger
changed the title
<ExampleComponent/>: Use HTML details accordion instead of custom JS button
Contributor
Author
|
Fixed it as best as I could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous use of custom JS buttons for the example accordions were breaking translation services like Google Translate or Baidu Translate.
I'm HOPING using standard HTML components lets them read this more easily, but I'm not sure...