chore: add taxonomy annotations and role-category labels to IAM roles for UI grouping#521
chore: add taxonomy annotations and role-category labels to IAM roles for UI grouping#521kevwilliams wants to merge 9 commits intomainfrom
Conversation
🤖 Automatically added newlines to 4 file(s) Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
🤖 I automatically added missing newlines at the end of 4 file(s) in this PR. All files should now end with a newline character as per coding standards. |
|
|
1 similar comment
|
|
…AM roles Adds taxonomy.miloapis.com/role-category label to all 72 IAM role files to support filterByLabel in the cloud portal UI. Three values are used: - platform: IAM, resource management, org/project, quota, core roles - feature: CRM notes and notification roles - service: reserved for infrastructure services (DNS, Network, Activity, etc.) Also adds missing taxonomy.miloapis.com/product and sort-order annotations to 24 previously unclassified roles (iam-admin/editor/viewer, identity session viewer, organizationmembership-*, core-*, apiextensions-reader, crm-note-*, quota-viewer, organization-quota-manager). Adds docs/architecture/identity-and-access-management/role-taxonomy.md as a reference for service teams adding roles in other repos.
🤖 Automatically added newlines to 4 file(s) Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
🤖 I automatically added missing newlines at the end of 4 file(s) in this PR. All files should now end with a newline character as per coding standards. |
|
@scotwells any thoughts on this? After we do this I can go through and add similar labels and annotations to the services e.g DNS etc. |
scotwells
left a comment
There was a problem hiding this comment.
@kevwilliams overall looks good, just some feedback on roles labeled with the platform label.
| labels: | ||
| quota.miloapis.com/role-type: viewer | ||
| quota.miloapis.com/service: quota | ||
| taxonomy.miloapis.com/role-category: platform |
There was a problem hiding this comment.
Think this would be a service level role? I see platform roles as the top-level "Owner", "Editor", "Viewer" roles and all other roles are either service or feature.
…x quota namespace - Change role-category from 'platform' to 'service' for all non-owner roles per feedback that 'platform' should be reserved for top-level owner/editor/viewer - Add missing taxonomy labels to new iam-organization-admin/editor/viewer roles - Remove hardcoded 'namespace: milo-system' from quota roles so they deploy to datum-cloud namespace and appear in the portal role selector
Summary
taxonomy.miloapis.com/role-categorylabel to all IAM role files to supportfilterByLabelin the cloud portal UItaxonomy.miloapis.com/productandtaxonomy.miloapis.com/sort-orderannotations to all previously unclassified rolesiam-organization-admin/editor/viewerrolesdocs/architecture/identity-and-access-management/role-taxonomy.mdas a reference for service teams defining roles in other reposRole categories
platformowner(future:editor,viewer)servicefeatureProduct groups
Test plan
filterByLabelontaxonomy.miloapis.com/role-category=featurereturns only Notes and Notification rolesfilterByLabelontaxonomy.miloapis.com/role-category=platformreturns onlyownerfilterByLabelontaxonomy.miloapis.com/role-category=servicereturns IAM, org/project, and core roles (not quota)