feat: add request changes review action#1
feat: add request changes review action#1IliasAlmerekov wants to merge 4 commits intodaulet:mainfrom
Conversation
| if self.list_state.selected() == Some(idx) { | ||
| AsyncResult::Diff(epoch, diff, delta_output, delta_too_large) => { | ||
| // Only update if this result belongs to the current detail session | ||
| if epoch == self.detail_epoch { |
There was a problem hiding this comment.
Using only detail_epoch to accept async results can still attach stale data to the wrong PR after a refresh. Refresh replaces self.prs/selection without bumping epoch, so in-flight results from the prior PR can pass epoch == self.detail_epoch and overwrite diff_cache/comments_cache/checks_cache for the newly selected PR. Consider validating both epoch and PR identity (e.g., repo+number), and/or increment epoch when refresh swaps the list while detail view is active.
There was a problem hiding this comment.
You are right, thanks for catching this, and sorry I missed it initially. I fixed it by validating detail async results with both epoch and PR identity, and by bumping/resetting the detail session when refresh lands in detail view.
3 participants
Adds ability to request changes on a PR from the TUI using Shift + R in detail view.