Skip to content

Fix visual glitch when drawing selection in wrapped entry #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davep merged 2 commits into from
Dec 2, 2025
Merged

Fix visual glitch when drawing selection in wrapped entry #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64ef26
:bug: Fix visual glitch when drawing selection in wrapped entry
davep Dec 2, 2025
ee79014
:books: Link the ChangeLog to the PR
davep Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
([#47](https://github.com/davep/aging/pull/47))
- Added Python 3.14 as a tested/supported Python version.
([#48](https://github.com/davep/aging/pull/48))
- Fixed a visual glitch with the "bounce bar" when an entry was wrapping its
content. ([#49](https://github.com/davep/aging/pull/49))

## v1.0.0

Expand Down
6 changes: 5 additions & 1 deletion src/aging/widgets/entry_viewer/entry_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,11 @@ def render_line(self, y: int) -> Strip:
text, no overriding colours.
"""
strip = super().render_line(y)
if self.scroll_offset.y + y == self.highlighted:
try:
option_index, _ = self._lines[self.scroll_offset.y + y]
except IndexError:
return strip
if option_index == self.highlighted:
if highlight := self.get_visual_style("option-list--option-highlighted"):
highlight_style = highlight.rich_style
# Despite its name, Style.without_color removes more than
Expand Down