fix: preserve pdf scroll position on dark mode toggle#2
Open
natiyeshi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem?
When switching between light and dark mode while reading a PDF, the viewer would auto-scroll back to the top of the document, losing the user's current reading position.
Root Cause
ColorFiltered was keyed with ValueKey(widget.settings.theme). In Flutter, changing a widget's key forces it to tear down and rebuild the entire subtree — including the PdfViewer inside it — which resets the scroll position to the top.
Fix
Removed the ValueKey from ColorFiltered. Since ColorFiltered only wraps the viewer with a color matrix, it doesn't need to rebuild when the theme changes — it simply updates the colorFilter in place. This keeps the PdfViewer alive across theme switches, preserving the scroll position.
Steps to Reproduce
Open any PDF
Scroll to any page beyond the first
Toggle dark/light mode from settings
✅ Scroll position is now preserved (was resetting to top before)
Changes
lib/screens/reading/widgets/pdf_view.dart — removed key: ValueKey(widget.settings.theme) from ColorFiltered