Skip to content

Created new block supporting enterprise wpa2#81

Open
DTV96Calibre wants to merge 3 commits into
davidferguson:masterfrom
DTV96Calibre:new-wifi-block
Open

Created new block supporting enterprise wpa2#81
DTV96Calibre wants to merge 3 commits into
davidferguson:masterfrom
DTV96Calibre:new-wifi-block

Conversation

@DTV96Calibre
Copy link
Copy Markdown

I tried integrating this into the existing block but there were issues and the interface wasn't great. This is cleaner.

@DTV96Calibre
Copy link
Copy Markdown
Author

I realized a while back that this pr isn't functional for a few reasons. Anyone interested in finishing this should do so before merging

@littleblackfish
Copy link
Copy Markdown

So what did you realize was missing? If you give me a list I'd like to polish it up.

@DTV96Calibre
Copy link
Copy Markdown
Author

The primary thing is that it's not listed under info.json under load order, which is a simple fix. I remember being unhappy with the way the block was separate from the main wifi block and there wasn't an easy way to make the dropdown menus dependent on selected options. I think there were other issues (likely code related), but I had moved on due to time constraints and don't remember what was wrong.

@littleblackfish
Copy link
Copy Markdown

And I suppose the reason you didn't like the modification to the main wifi block was that the number of arguments are different, right?

@DTV96Calibre
Copy link
Copy Markdown
Author

I don't mind increasing the number of arguments. The issue is that without figuring out how to hide individual input fields in the block, you'll end up with two "password" fields which serve different purposes and a username field which you shouldn't use unless you're doing enterprise WPA2. They could always ignore the extra fields but it was going to be confusing to most people, especially those who are looking for such a user friendly way to customize their Pi's OS installation.

@DTV96Calibre
Copy link
Copy Markdown
Author

If you kept the blocks separate, this is pretty much a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants