Skip to content

Fix tally inspect amount sign inference for negative-debit CSVs#87

Draft
Copilot wants to merge 15 commits intomainfrom
copilot/fix-negative-debits-issues
Draft

Fix tally inspect amount sign inference for negative-debit CSVs#87
Copilot wants to merge 15 commits intomainfrom
copilot/fix-negative-debits-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

  • Inspect the current tally inspect amount-sign reporting code and tests
  • Remove threshold-based sign interpretation from inspect
  • Make inspect report only the observed sign data and generic token behavior
  • Update inspect regression tests for the new output
  • Run relevant tests after the change
  • Store any durable repo facts verified during the task

Copilot AI linked an issue Apr 11, 2026 that may be closed by this pull request
Copilot AI and others added 3 commits April 11, 2026 05:48
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/255e41f5-a5dd-4f02-b05a-3bcec9963882

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/255e41f5-a5dd-4f02-b05a-3bcec9963882

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/255e41f5-a5dd-4f02-b05a-3bcec9963882

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix handling of negative debits in CSV reports Fix tally inspect amount sign inference for negative-debit CSVs Apr 11, 2026
Copilot AI requested a review from davidfowl April 11, 2026 05:51
@github-actions
Copy link
Copy Markdown

PR Build Available

Version: 0.0.87-555bddc

Install from this PR

Linux / macOS:

curl -fsSL https://raw.githubusercontent.com/davidfowl/tally/main/docs/install-pr.sh | bash -s -- 87

Windows PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/davidfowl/tally/main/docs/install-pr.ps1) } 87"

Manual download: View workflow run and download artifacts.

Requirements
  • GitHub CLI (gh) must be installed and authenticated
  • Run gh auth login if not already authenticated

Copilot AI and others added 5 commits April 11, 2026 05:57
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/8ba8ec62-9f28-4226-b7cc-88ecdb4a3555

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/8ba8ec62-9f28-4226-b7cc-88ecdb4a3555

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/8ba8ec62-9f28-4226-b7cc-88ecdb4a3555

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/8ba8ec62-9f28-4226-b7cc-88ecdb4a3555

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/8ba8ec62-9f28-4226-b7cc-88ecdb4a3555

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot AI and others added 6 commits April 11, 2026 06:09
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/47a849c0-779f-4f57-aea2-e5c955aacdd6

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/47a849c0-779f-4f57-aea2-e5c955aacdd6

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/47a849c0-779f-4f57-aea2-e5c955aacdd6

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/47a849c0-779f-4f57-aea2-e5c955aacdd6

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/47a849c0-779f-4f57-aea2-e5c955aacdd6

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/davidfowl/tally/sessions/47a849c0-779f-4f57-aea2-e5c955aacdd6

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSVs with negative debits

2 participants