Merged
Conversation
Contributor
|
The original code in pet.S is correct. 1f is not 0x1f hexadecimal, but one-forward, i.e. the 1: label found when searching forwards. It's self-modifying code. The 0xffff gets replaced by the contents of A and X. |
…nterpart" This reverts commit 1d92921.
Contributor
Author
okay, I should have thought more about this, reverted. |
davidgiven
reviewed
Mar 6, 2026
Owner
|
Taken a look, sorry about the delay! Left a comment. |
nick-less
force-pushed
the
fix_misc_errors
branch
from
97b1ccf to
f79219d
Compare
Owner
|
Great, thanks! Merging. Sorry it took so long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a problem I've stumbled across.