fix: Ensure ctrl-space is fed through from WinTerminal to neovim#80
Merged
Conversation
more details: <https://harrymin.dev/posts/fix-terminal-keybindings-csi-u/> also remove long-obsolete settings.json (was replaced with the intro of configWinTerm.ps1)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows Terminal configuration flow so Ctrl+Space is sent through as a CSI-u sequence (so Neovim can distinguish it), and removes an obsolete repo-tracked Terminal settings file in favor of the existing configWinTerm.ps1-based approach.
Changes:
- Add a Windows Terminal
sendInputaction forctrl+spacethat emits the CSI-u escape (ESC[32;5u) for Neovim compatibility. - Delete
win/settings.json, which is no longer used now that Terminal configuration is managed viawin/configWinTerm.ps1. - Remove outdated bootstrap comments referring to initializing Terminal settings JSON manually.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| win/settings.json | Removes the old, repo-tracked Windows Terminal settings file. |
| win/configWinTerm.ps1 | Adds ctrl+space → sendInput CSI-u mapping during settings generation. |
| bootstrap.ps1 | Removes obsolete comments about Terminal settings initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more details: https://harrymin.dev/posts/fix-terminal-keybindings-csi-u/
also remove long-obsolete settings.json (was replaced with the intro of configWinTerm.ps1)