Skip to content

Comments

fix(interface): sync theme dropdown with library state on init#73

Open
ExtremeAntonis wants to merge 1 commit intodawid-scripts:masterfrom
ExtremeAntonis:fix/interface-theme-persistence
Open

fix(interface): sync theme dropdown with library state on init#73
ExtremeAntonis wants to merge 1 commit intodawid-scripts:masterfrom
ExtremeAntonis:fix/interface-theme-persistence

Conversation

@ExtremeAntonis
Copy link

@ExtremeAntonis ExtremeAntonis commented Jan 26, 2026

Currently, InterfaceManager hardcodes the theme to "Dark" on startup, ignoring the theme set in CreateWindow. This change makes the dropdown check Library.Theme instead, so it respects the developer's choice.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the theme dropdown in Interface settings to correctly display the currently active theme.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

This change modifies the initial value binding for the InterfaceTheme dropdown in the Interface Manager from using the saved Settings.Theme to the current Library.Theme, altering which theme appears selected by default.

Changes

Cohort / File(s) Summary
Theme Binding Update
Addons/InterfaceManager.lua
Changed the InterfaceTheme dropdown's initial value binding from Settings.Theme to Library.Theme, affecting the displayed default theme in the Interface section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A theme by any binding flows,
From settings deep to library's glow,
The dropdown now shows what truly is,
Not what was saved, but what exists!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: switching the theme dropdown initialization from saved settings to library state, which aligns with the PR's objective to respect the developer's theme choice.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant