Skip to content

Add Access-Control-Allow-Origin header to response#9

Open
JervenBolleman wants to merge 1 commit into
dbcls:mainfrom
JervenBolleman:cors
Open

Add Access-Control-Allow-Origin header to response#9
JervenBolleman wants to merge 1 commit into
dbcls:mainfrom
JervenBolleman:cors

Conversation

@JervenBolleman

Copy link
Copy Markdown

To make it easier to develop JS webapps against sparql-proxy we set the CORS header to '*'. There is a cors config to turn it off

…he CORS header to '*'. There is a cors config to turn it off
@skwsm skwsm requested a review from ursm September 6, 2019 05:08
@ursm

ursm commented Sep 6, 2019

Copy link
Copy Markdown
Collaborator

Thank you for your suggestion. We will already provide the same functionality through cors() express middleware. Isn't it working as you expected?

router.all('/sparql', cors(), multer().array(), async (req, res) => {

image

@JervenBolleman

Copy link
Copy Markdown
Author

We where confused because these are not set on error pages such as 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants