Skip to content

Conversation

@inverse
Copy link

@inverse inverse commented Oct 17, 2025

  • Replace flake8 with ruff and other pre-commit hooks for linting/quality
  • use mise to manage this for other devs

@dberrocal-git
Copy link
Owner

Im thinking the pre-commit/action might be a bit overkill for a project of this size. It adds an extra layer of configuration) for what is currently just a single file

What do you think about simplifying this by using just ruff?

We could replace the linting/pre-commit steps with a much simpler, single step:

- name: Lint and Format with Ruff
  run: |
    pip install ruff
    ruff check .
    ruff format --check .

This would be simpler to maintain, with no extra stuff

@inverse
Copy link
Author

inverse commented Oct 21, 2025

Are you referring to the pre-commit framework? Sure it's an additional bit of configuration but it's not something you change often aside bumping the pinned repos.

I think fixing things locally vs on CI has it's advantage and should make it easier for contributors.

@dberrocal-git dberrocal-git requested a review from Copilot October 25, 2025 12:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the linting setup by replacing flake8 with ruff and introduces pre-commit hooks to automate code quality checks. The changes include removing the old flake8 dependency, configuring ruff with a 120-character line length, and setting up automated formatting and linting through GitHub Actions.

  • Replaced flake8 with ruff for linting and formatting
  • Added pre-commit configuration with multiple hooks (ruff, isort, mypy, and standard pre-commit checks)
  • Updated CI workflow to use pre-commit/action instead of manual linting

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test.py Applied automated formatting: import sorting, multi-line formatting adjustments, and list formatting
requirements-test.txt Removed flake8 dependency
pyproject.toml Added ruff configuration with 120-character line length
mise.toml Added pre-commit tool version management
haaska.py Applied automated formatting for function calls and parameter lists
.pre-commit-config.yaml Added comprehensive pre-commit hooks configuration
.github/workflows/main.yml Replaced manual linting steps with pre-commit action

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dberrocal-git
Copy link
Owner

Ok, but now that I've merged the commit #1, we need to update the base, and I would be able to merge it

@inverse
Copy link
Author

inverse commented Nov 6, 2025

Updated

@dberrocal-git dberrocal-git merged commit 8d51e36 into dberrocal-git:master Nov 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants