Skip to content

fix(bigquery): make the priority profile setting an enum - #16144

Open
fornwall wants to merge 1 commit into
dbt-labs:mainfrom
fornwall:bigquery-priority
Open

fornwall wants to merge 1 commit into
dbt-labs:mainfrom
fornwall:bigquery-priority

Conversation

@fornwall

@fornwall fornwall commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Make the bigquery priority a ["batch", "interactive"] enum instead of a string, aligning with the docs and dbt 1.x behaviour.

In the next dbt-labs/dbt-jsonschema sync the schema will change from:

"priority": { "type": ["string", "null"] }

to

"priority": { "anyOf": [ {"$ref": "#/definitions/BigqueryPriority"}, {"type": "null"} ] }
"BigqueryPriority": { "type": "string", "enum": ["batch", "interactive"] }

Related: #16021, b3a7c68.

@fornwall
fornwall requested a review from a team as a code owner August 31, 2026 22:56
@cla-bot cla-bot Bot added the cla:yes label Aug 31, 2026
codescene-delta-analysis[bot]

This comment was marked as outdated.

codescene-delta-analysis[bot]

This comment was marked as outdated.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Failed
Enforce advisory code health rules (1 file with Complex Method)

Our agent can fix these. Install it.

Gates Passed
3 Quality Gates Passed

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
dbt_cloud_client.rs 1 advisory rule 7.99 → 7.93 Suppress

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Comment thread crates/dbt-init/src/dbt_cloud_client.rs
@fornwall fornwall changed the title fix(bigquery): honor the priority profile setting fix(bigquery): make the priority profile setting an enum Sep 17, 2026
Type the priority BigQuery profile configuration as a
["batch", "interactive"] enum instead of a string, aligning us with
the docs and dbt 1.x behaviour, and map it to the driver's
`BATCH`/`INTERACTIVE` constants instead of uppercasing whatever the
profile happens to contain.

Fixes dbt-labs#16021.

Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant