Skip to content

fix(databricks): emit only changed columns in column-tag diffs - #16247

Open
sd-db wants to merge 2 commits into
dbt-labs:mainfrom
sd-db:sd-db/fix/databricks-column-tags-changed-columns-diff
Open

fix(databricks): emit only changed columns in column-tag diffs#16247
sd-db wants to merge 2 commits into
dbt-labs:mainfrom
sd-db:sd-db/fix/databricks-column-tags-changed-columns-diff

Conversation

@sd-db

@sd-db sd-db commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align Databricks column-tag alter diffs with dbt-databricks ColumnTagsConfig.get_diff: only columns whose tag maps differ, each with the full desired tag map.
  • Column-name comparison is case-insensitive, matching v1.
  • Expand unit coverage (empty desired, mixed maps, unchanged siblings, case-insensitive names).

Fixes #16246

Test plan

  • cargo test --offline -p dbt-adapter --lib column_tags
  • Confirm incremental/table alter still issues ALTER COLUMN … SET TAGS only for columns in the changeset

@sd-db
fix(databricks): emit only changed columns in column-tag alter diffs
8d3219b 
Match dbt-databricks ColumnTagsConfig.get_diff so unchanged sibling
columns are not re-SET during alter.

Fixes dbt-labs#16246
@sd-db
sd-db requested a review from a team as a code owner September 8, 2026 13:02
@cla-bot cla-bot Bot added the cla:yes label Sep 8, 2026
codescene-delta-analysis[bot]

This comment was marked as outdated.

Sign in to view

codescene-delta-analysis[bot]
codescene-delta-analysis Bot reviewed Sep 8, 2026
View reviewed changes

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Failed
Enforce advisory code health rules (1 file with Code Duplication)

Our agent can fix these. Install it.

Gates Passed
3 Quality Gates Passed

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
column_tags.rs 1 advisory rule 9.39 → 8.82 Suppress

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@xuliangs xuliangs added the ci:approve-public-fork-ci Maintainer approval to run secret-bearing CI on a public fork PR. Auto-removed on each new push. label Sep 9, 2026
@fa-assistant

fa-assistant commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks again for your contribution! 🎉

Your changes have been mirrored to our upstream review repository, and a maintainer will take a look there. There's nothing more for you to do right now — please feel free to keep the discussion going in this thread and we'll respond.

When the upstream change is merged, it'll land here through our regular sync from main, and we'll close this PR for you automatically.

This was referenced Sep 10, 2026
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci:approve-public-fork-ci Maintainer approval to run secret-bearing CI on a public fork PR. Auto-removed on each new push. cla:yes community review-status: in-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(databricks): emit only changed columns in column-tag alter diffs

3 participants

@sd-db @fa-assistant @xuliangs