Conversation
Repoints repo-facing URLs at dbt-labs/dbt, and the README CI badge at this repo's ci.yml instead of v1's main.yml, which rendered as failing on the dbt-core and dbt-oss PyPI pages.
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several repository URLs remain stale in changelog, release workflow, and Cargo metadata references.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates repository-facing links from dbt-core to dbt following the repository rename.
Changes:
- Updates PyPI metadata, CI badges, workflows, templates, and issue links.
- Refreshes repository naming in maintainer documentation and changelog templates.
File summaries
| File | Reviewed changes |
|---|---|
README.md |
Updated CI badge links. |
pyproject.toml |
Updated project and issue URLs. |
.github/workflows/test-repeater.yml |
Updated repository references. |
.github/workflows/release-awaiting.yml |
Updated repository references. |
.github/workflows/docs-issue.yml |
Updated issue links and wording. |
.github/workflows/changelog-existence.yml |
Updated contributing-guide URL. |
.github/workflows/auto-public-pr-copybara.yml |
Updated repository naming. |
.github/pull_request_template.md |
Updated contributing-guide URL. |
.github/ISSUE_TEMPLATE/implementation-ticket.yml |
Updated maintainer naming. |
.github/ISSUE_TEMPLATE/feature-request.yml |
Updated discussions URL. |
.github/ISSUE_TEMPLATE/config.yml |
Updated discussions URL. |
.github/CODEOWNERS |
Updated repository naming. |
.github/_README.md |
Updated Actions URLs. |
.changes/header.tpl.md |
Updated changelog repository URL. |
Review details
Suppressed comments (2)
.changes/header.tpl.md:5
CHANGELOG.mdis the configured generated output (.changie.yaml:5) and its header still contains the olddbt-labs/dbt-core/blob/1.latestURL at line 5. Please regenerate/update the checked-in changelog in this PR as well; otherwise the public changelog continues to send readers to the renamed repository.
- dbt Core v1 (Python) changelog, see [the `1.latest` branch's `CHANGELOG.md`](https://github.com/dbt-labs/dbt/blob/1.latest/CHANGELOG.md).
README.md:5
- The rename is incomplete for the other live release workflows:
.github/workflows/publish-homebrew.yml:50,93and.github/workflows/publish-winget.yml:84still construct download URLs underdbt-labs/dbt-core. Those workflows publish v2 artifacts, so their generated installer links continue to advertise the old repository; update those URLs in the same change.
<a href="https://github.com/dbt-labs/dbt/actions/workflows/ci.yml">
- Files reviewed: 14/14 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - This file covers dbt Core v2.0. For changelogs for other dbt Engines, refer to: | ||
| - dbt Core v1 (Python) changelog, see [the `1.latest` branch's `CHANGELOG.md`](https://github.com/dbt-labs/dbt-core/blob/1.latest/CHANGELOG.md). | ||
| - dbt Core v1 (Python) changelog, see [the `1.latest` branch's `CHANGELOG.md`](https://github.com/dbt-labs/dbt/blob/1.latest/CHANGELOG.md). |
| Homepage = "https://getdbt.com" | ||
| Repository = "https://github.com/dbt-labs/dbt-core" | ||
| Issues = "https://github.com/dbt-labs/dbt-core/issues" | ||
| Repository = "https://github.com/dbt-labs/dbt" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoints repo-facing URLs at
dbt-labs/dbtfollowing the repo rename: issue templates, CODEOWNERS, workflow links, changelog header, and the[project.urls]inpyproject.toml.Also switches the README CI badge from v1's
main.ymlto this repo'sci.yml. The old badge resolved to the legacy Python workflow and rendered as failing; it now tracks Rust CI onmain.