Pie-chart radius as per resizing of window.#1279
Open
fatangare wants to merge 1 commit intodc-js:developfrom
Open
Pie-chart radius as per resizing of window.#1279fatangare wants to merge 1 commit intodc-js:developfrom
fatangare wants to merge 1 commit intodc-js:developfrom
Conversation
During resizing of pie-chart, chart is redrawn for given width and height but it's radius is not changed making it to be cropped. Simple solution is to check if diameter is bigger than container...if yes, adjust radius accordingly.
Contributor
|
Hi, @fatangare have you tried with the responsive width(0) way? Does it behave properly in that case? |
Contributor
|
I doubt that would help, however another workaround is just to not set the radius and let it be derived from the width/height. I'm in favor of this PR, sorry I have not yet had time to merge it. Since it doesn't change the API it should be okay for the 2.0 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During resizing of pie-chart, chart is redrawn for given width and height but its radius is not changed making it to be cropped. Simple solution is to check if diameter is bigger than container...if yes, adjust radius accordingly.