Alternate bar chart implementation and layer-mixin [WIP]#979
Open
alan-unravel wants to merge 6 commits intodc-js:developfrom
Open
Alternate bar chart implementation and layer-mixin [WIP]#979alan-unravel wants to merge 6 commits intodc-js:developfrom
alan-unravel wants to merge 6 commits intodc-js:developfrom
Conversation
…ixin_update Conflicts: src/bar-chart.js src/line-chart.js
alan-unravel
changed the title
Contributor
|
Thanks for putting this together @alan-unravel. Just wanted to post the jsfiddle's for some additional resources: |
Contributor
Author
|
No problem @mtraynham, I'm going ahead with the short term solution now, but this should probably be left open with a view to bring it in in v3 maybe ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
courtesy of @mtraynham