Fetch natives via go run dcc-bigfred/common/cmd/fetch - #12
Merged
Conversation
Drop ORAS/GHCR pull; Makefile clones dcc-bigfred/.github @ v2 and uses curl-based Actions/Release download (no gh CLI). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Drop .ci-github clone/bootstrap; require Go on the host for tip/Release native fetches. Co-authored-by: Cursor <cursoragent@cursor.com>
keskad
changed the title
Drop the one-off release-asset shell script; Gradle stages through make. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Stop pulling native binaries from ORAS/GHCR and from one-off curl/Python shell scripts. The Android client should fetch loco-server, microinit, and valkey the same way as the rest of the org:
go run github.com/dcc-bigfred/common/cmd/fetch@latest, with tip → Actions artifacts andlatest-release/v*→ GitHub Releases.This PR is a consumer of binaries published by bigfred, microinit, and deps-android-valkey.
Summary
.ci-githubbootstrap withgo run …/cmd/fetch@latestin Makefilemake loco-android/make microinit-android— tip or Release from GitHubmake valkey-android—latest-releasefromdcc-bigfred/deps-android-valkeyfetchNativeBinariesstages viamaketargets (no standalone fetch scripts)fetch-ghcr-oras.shandfetch-github-release-asset.shGITHUB_TOKEN/GH_TOKEN/BIGFRED_NATIVE_TOKENRelated work
main@v0.1.2/v2cmd/fetchimplementationloco-server-android-arm64to Releases / CI artifactslibmicroinit.soAndroid artifactSuggested merge order: common (done) → bigfred + microinit → this PR.
Test plan
command -v goandGITHUB_TOKENavailablemake loco-android microinit-android valkey-android(ormake native-prebuilt) succeedsmake apk/ CI embedslibloco-server.so,libmicroinit.so,libvalkey-server.so