Tag-driven Android versionName/versionCode - #9
Merged
Conversation
Wire CI and Gradle to a single scripts/android-version.py so release tags v* stamp the APK, while local/main builds use latest tag + -dev. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/android-version.pyas the single source of truth: onv*GitHub tags setversionName/versionCodefrom the tag; otherwise use latestv*tag with leadingvstripped and-devsuffix (0.0.0-devif none).VERSION_*env overrides or runs the script; CI logs the resolved version, fetches full git history/tags, and asserts APK badging matches.Test plan
*-dev(or0.0.0-dev), APK badging matchespython3 scripts/android-version.pyand withGITHUB_REF_TYPE=tag GITHUB_REF_NAME=v1.2.3vX.Y.Ztag and confirm release APK has matchingversionName/versionCodeMade with Cursor