ci(sdk-smoke): pin the nightly to the published SDK 5.0.0 - #194
Merged
Conversation
@percolatorct/sdk@5.0.0 is on npm as of 2026-08-28, carrying the NFT_PROGRAM_ID fix (percolator-sdk#372): the ABI previously exported the MAINNET nft address while every other id in the SDK is devnet, so any consumer importing it targeted a program that returns AccountNotFound. The comment above this pin says updating it is deliberate, and that is the point -- the smoke job should name the version it actually smokes. Note this repo consumes the SDK at runtime via file:../../percolator-sdk, a LOCAL DIRECTORY, so this pin governs the nightly smoke job only, not what the deployed service loads. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@percolatorct/sdk@5.0.0is on npm as of 2026-08-28, carrying theNFT_PROGRAM_IDfix (dcccrypto/percolator-sdk#372): the ABI previously exported the mainnet nft address while every other id in the SDK is devnet, so any consumer importing it targeted a program that returnsAccountNotFound.The comment above this pin says updating it is deliberate — that is the point. The smoke job should name the version it actually smokes.
Worth knowing
This repo consumes the SDK at runtime via
file:../../percolator-sdk— a local directory, not a version. So this pin governs the nightly smoke job only, not what the deployed service loads. Publishing 5.0.0 did not by itself change the running indexer.🤖 Generated with Claude Code
https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D