Skip to content

fix(#2286): scroll-lock gap + scrim outlier in trade modals #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcccrypto merged 1 commit into from
Sep 3, 2026
Merged

fix(#2286): scroll-lock gap + scrim outlier in trade modals #2537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/trade/FundingExplainerModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { FC, useEffect, useRef } from "react";
import { createPortal } from "react-dom";
import gsap from "gsap";
import { usePrefersReducedMotion } from "@/hooks/usePrefersReducedMotion";
import { useLockBodyScroll } from "@/hooks/useLockBodyScroll";

interface FundingExplainerModalProps {
onClose: () => void;
Expand All @@ -13,6 +14,10 @@ export const FundingExplainerModal: FC<FundingExplainerModalProps> = ({ onClose
const overlayRef = useRef<HTMLDivElement>(null);
const modalRef = useRef<HTMLDivElement>(null);
const prefersReduced = usePrefersReducedMotion();
// #2286: this was the ONE modal of the five without a scroll lock, so the
// page scrolled behind it. The other four already call this hook; the
// divergence the issue describes is now down to this and the scrim.
useLockBodyScroll();

// Keep the onClose callback in a ref so the mount effect never re-runs on parent
// re-renders. The parent FundingRateCard runs a 1-second `setCountdown` setInterval,
Expand Down
2 changes: 1 addition & 1 deletion app/components/trade/SendPositionNftModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export const SendPositionNftModal: FC<SendPositionNftModalProps> = ({
onClick={(e) => {
if (e.target === e.currentTarget && !loading) onCancel();
}}
className="fixed inset-0 z-[9999] flex items-center justify-center bg-black/60 backdrop-blur-[2px] p-4"
className="fixed inset-0 z-[9999] flex items-center justify-center bg-black/80 p-4"
aria-modal="true"
role="dialog"
aria-label="Send Position NFT"
Expand Down
Loading