Skip to content

docs(#160): point the layout-validation deferral at a tracker that still exists - #187

Merged
dcccrypto merged 1 commit into
mainfrom
fix/160-doc-claims
Sep 2, 2026
Merged

docs(#160): point the layout-validation deferral at a tracker that still exists#187
dcccrypto merged 1 commit into
mainfrom
fix/160-doc-claims

Conversation

@dcccrypto

Copy link
Copy Markdown
Owner

Docs only. No code change.

README.md:130 deferred runtime layout validation to "#110H". #110 is closed — it was a batch of LOW/INFO findings — so the deferral pointed at something that no longer tracks it. Now points at #160, which is open and raised this.

Small, but it is the failure mode where a known gap quietly stops being known: the doc says "deferred, see X", a reader checks X, finds it closed, and concludes the work was done.

Also states what the assertions cannot do, and why

The existing wording ("verify internal consistency ... not alignment with the live engine") is correct but undersells it. The sharper statement:

Under the exact change they exist to guard against — raising the asset count — whoever made it would update EXPECTED_PORTFOLIO_ACCOUNT_SIZE to whatever the (wrong) struct computed, and the assertion would pass.

It is not weak evidence of layout correctness. In precisely the scenario it guards, it is guaranteed to pass. That is worth a reader knowing before they trust it.

Status of #160's three reported claims

All three are already corrected on main, verified rather than assumed:

  • no LiteSVM reference remains anywhere in the repo (grep -rln -i litesvm src/ tests/ Cargo.toml → empty)
  • README.md and src/slab_types_v16.rs both now say the const_assert!s do not verify engine alignment
  • a tests/ directory now exists (5 PoC files), so "there is no tests/ directory" is outdated

What remains is the substantive half — runtime validation of the mirror against a real portfolio account — which #160 stays open for. #185 (merged today) removed one concrete instance of the drift vector by deriving V16_ACTIVE_BITMAP_WORDS from the asset count rather than hardcoding it.

nft suite: 11 + 6 + 5 + 5 + 4 passing, 0 failed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D

…ill exists

README deferred runtime layout validation to "#110H". #110 is CLOSED — it was a
batch of LOW/INFO findings — so the deferral was documented as tracked somewhere
that no longer tracks it. Now points at #160, which is open and is the issue that
raised this.

Small, but this is the failure mode where a known gap stops being known: the doc
says "deferred, see X", a reader checks X, finds it closed, and concludes the
work was done.

Also states plainly what the const_assert!s cannot do, because the reason is
sharper than "they only check internal consistency". Under the exact change they
exist to guard against — raising the asset count — whoever made it would update
EXPECTED_PORTFOLIO_ACCOUNT_SIZE to whatever the wrong struct computed, and the
assertion would pass. It is not weak evidence; in that scenario it is guaranteed
to pass.

#185 (merged today) removed one concrete instance of that vector by deriving
V16_ACTIVE_BITMAP_WORDS from the asset count. The general case still needs a real
portfolio account decoded at runtime, which is what #160 stays open for.

The three false LiteSVM/compile-time claims #160 reported are already corrected in
both README.md and src/slab_types_v16.rs — verified, no LiteSVM reference remains
anywhere in the repo.

nft suite: 11 + 6 + 5 + 5 + 4 passing, 0 failed.

Refs: #160

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D
@dcccrypto
dcccrypto merged commit 61b1865 into main Sep 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 94a11c89-83ee-4247-a804-10df54f9eca5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant