Skip to content

fix(specs): refresh matcher parity fixture after the 585f492 to d4d4f1c redeploy - #374

Merged
dcccrypto merged 1 commit into
mainfrom
fix/matcher-parity-drift
Aug 28, 2026
Merged

fix(specs): refresh matcher parity fixture after the 585f492 to d4d4f1c redeploy#374
dcccrypto merged 1 commit into
mainfrom
fix/matcher-parity-drift

Conversation

@dcccrypto

Copy link
Copy Markdown
Owner

parity-check has been failing with [percolator-match] DRIFT DETECTED. The cause is the matcher devnet redeploy on 2026-08-25, not any SDK change: the committed spec still described 585f492 while the matcher moved to d4d4f1c.

This is exactly what the check exists to catch, and it caught it.

The drift is entirely additive

change from
BatchMatcherCall tag 3 — new 76b7106 batch multi-fill ABI
MATCHER_BATCH_HEADER_LEN 18, MATCHER_BATCH_LEG_LEN 26, MATCHER_BATCH_MAX_LEGS 16 — new same
insurance_fee_remainder_e6 @ 168 — new 64fa492 BUG-101 remainder carry
_reserved 168 → 176 shifted by the field above

Nothing removed, no tag renumbered, so no existing encoder changes meaning.

Verified locally: [percolator-match] parity OK, suite 1008 passed / 31 skipped.

One thing worth knowing about this check

The other three targets — percolator-prog, percolator-stake, percolator-nft — report cargo run failed in CI and locally, because they have no sdk_parity_fixtures bin. So parity-check currently validates only the matcher. Worth either adding the bin to those repos or being explicit that the check is matcher-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D

…1c redeploy

parity-check has been failing with "[percolator-match] DRIFT DETECTED". The cause is
the matcher devnet redeploy on 2026-08-25, not any SDK change: the committed spec still
described 585f492 while the matcher moved to d4d4f1c.

The drift is entirely ADDITIVE and maps to specific commits in that range:

  BatchMatcherCall tag 3                       new   (76b7106, batch multi-fill ABI)
  MATCHER_BATCH_HEADER_LEN 18 / LEG_LEN 26     new   (same)
  MATCHER_BATCH_MAX_LEGS 16                    new   (same)
  insurance_fee_remainder_e6 @ 168             new   (64fa492, BUG-101 remainder carry)
  _reserved 168 -> 176                         shifted by the field above

Nothing removed, no tag renumbered, so no existing encoder changes meaning. Verified
locally: [percolator-match] parity OK, and the suite is 1008 passed / 31 skipped.

Worth noting the other three targets (prog, stake, nft) report "cargo run failed" in
CI as well as locally -- they have no sdk_parity_fixtures bin -- so this check only
actually validates the matcher today.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 951ebbf7-8cef-4768-b572-0a6c8339bc72


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dcccrypto
dcccrypto merged commit be751b8 into main Aug 28, 2026
3 of 4 checks passed
@dcccrypto
dcccrypto deleted the fix/matcher-parity-drift branch August 28, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant