fix(specs): refresh matcher parity fixture after the 585f492 to d4d4f1c redeploy - #374
Merged
Conversation
…1c redeploy parity-check has been failing with "[percolator-match] DRIFT DETECTED". The cause is the matcher devnet redeploy on 2026-08-25, not any SDK change: the committed spec still described 585f492 while the matcher moved to d4d4f1c. The drift is entirely ADDITIVE and maps to specific commits in that range: BatchMatcherCall tag 3 new (76b7106, batch multi-fill ABI) MATCHER_BATCH_HEADER_LEN 18 / LEG_LEN 26 new (same) MATCHER_BATCH_MAX_LEGS 16 new (same) insurance_fee_remainder_e6 @ 168 new (64fa492, BUG-101 remainder carry) _reserved 168 -> 176 shifted by the field above Nothing removed, no tag renumbered, so no existing encoder changes meaning. Verified locally: [percolator-match] parity OK, and the suite is 1008 passed / 31 skipped. Worth noting the other three targets (prog, stake, nft) report "cargo run failed" in CI as well as locally -- they have no sdk_parity_fixtures bin -- so this check only actually validates the matcher today. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parity-checkhas been failing with[percolator-match] DRIFT DETECTED. The cause is the matcher devnet redeploy on 2026-08-25, not any SDK change: the committed spec still described585f492while the matcher moved tod4d4f1c.This is exactly what the check exists to catch, and it caught it.
The drift is entirely additive
BatchMatcherCalltag 3 — new76b7106batch multi-fill ABIMATCHER_BATCH_HEADER_LEN18,MATCHER_BATCH_LEG_LEN26,MATCHER_BATCH_MAX_LEGS16 — newinsurance_fee_remainder_e6@ 168 — new64fa492BUG-101 remainder carry_reserved168 → 176Nothing removed, no tag renumbered, so no existing encoder changes meaning.
Verified locally:
[percolator-match] parity OK, suite 1008 passed / 31 skipped.One thing worth knowing about this check
The other three targets —
percolator-prog,percolator-stake,percolator-nft— reportcargo run failedin CI and locally, because they have nosdk_parity_fixturesbin. Soparity-checkcurrently validates only the matcher. Worth either adding the bin to those repos or being explicit that the check is matcher-only.🤖 Generated with Claude Code
https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D